• Registered: 2008-07-08
  • Posts: 5

Topic: Inline detection and textareas

I've noticed that the inline detection doesn't check what the text's parent node is before applying the iframe.  This is a big problem when you have encrypted text in a textarea.  The encrypted text will magically disappear.  You can see what I mean here:

http://inspirationdate.net/code/firegpg.php


I played around a bit with the code and got it working by adding this to the HandlePage method:

if (node.parentNode.nodeName == 'TEXTAREA')
    break;

after

if (node.textContent.indexOf(Keyring.Tags.PgpBlockStart, idx) == -1)
    break;

I haven't done very much testing or anything.  Hope this helps though.

  • From: Geneva
  • Registered: 2007-04-04
  • Posts: 1,040

Re: Inline detection and textareas

Ok, already reported wink ( http://firegpg.tuxfamily.org/forum/view … 1142#p1142 )

THanks ^^'

the_glu's Website

  • Registered: 2008-07-08
  • Posts: 5

Re: Inline detection and textareas

That link just points to my post.

I did a search and couldn't find anything.  Oh well.

  • From: Geneva
  • Registered: 2007-04-04
  • Posts: 1,040

Re: Inline detection and textareas

Ok, fixed, and yes false link wink
http://bugs.getfiregpg.org/index.php?do … ;sort=desc

Thanks for your report wink

the_glu's Website

  • Registered: 2008-07-08
  • Posts: 5

Re: Inline detection and textareas

ah yes, the bug tracker.

thanks for the fix, it was bothering me enough to debug it myself smile.

  • usim
  • New member
  • Offline
  • Registered: 2008-02-15
  • Posts: 6

Re: Inline detection and textareas

How do I get an old version of FireGPG until a release is made with this fix?  FireGPG erases the very information I need to see!  The old version worked just fine.

Thanks

  • From: Geneva
  • Registered: 2007-04-04
  • Posts: 1,040

Re: Inline detection and textareas

Have a look on the install page wink

Regards,

the_glu's Website

  • usim
  • New member
  • Offline
  • Registered: 2008-02-15
  • Posts: 6

Re: Inline detection and textareas

I actually did look on the install page--first thing.  But I'm afraid I don't see how to get an OLD version of FireGPG on the install page.  I read every word.  Nothing about old versions.  Just a link to download the current version--which is broke for what I need.

  • From: Geneva
  • Registered: 2007-04-04
  • Posts: 1,040

Re: Inline detection and textareas

"For people who make packages for linux, or simply if you need it, you can use the url http://getfiregpg.org/stable/firegpg-version.xpi (or tar.gz) to get a specific version."

So http://getfiregpg.org/stable/firegpg-0.4.9.xpi .

the_glu's Website

  • Registered: 2008-07-08
  • Posts: 5

Re: Inline detection and textareas

you can get the version numbers from the news page: http://getfiregpg.org/news.html

i grabbed the svn though.

Last edited by InspirationDate (2008-07-09 17:11:56)

  • usim
  • New member
  • Offline
  • Registered: 2008-02-15
  • Posts: 6

Re: Inline detection and textareas

I read that paragraph three times but never thought it had anything to do with getting an old version of FireGPG.  Who would think that the paragraph about creating linux packages is actually telling everyone how to get the non-latest version of FireGPG?  I would lead with "To get a previous version of FireGPG...".

  • From: Florida, United States
  • Registered: 2008-03-28
  • Posts: 5

Re: Inline detection and textareas

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alternatively, you can simply disable the inline detection. It's available on the General tab of the FireGPG options.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: http://getfiregpg.org

iD8DBQFIe1i814T0zKYaQO0RAktvAKCwLGutu/Egs8IpZ3TSGfTVWkZu1gCbBGc6
vLshP9c5LUiV3qz3OfNoBCo=
=RNzr
-----END PGP SIGNATURE-----

  • From: Geneva
  • Registered: 2007-04-04
  • Posts: 1,040

Re: Inline detection and textareas

Last version should fix the proble btw wink

the_glu's Website